Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#851 fix scaling bug in current data #852

Merged
merged 2 commits into from
Feb 24, 2020
Merged

#851 fix scaling bug in current data #852

merged 2 commits into from
Feb 24, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Feb 24, 2020

Description

Fixes a bug where current data was being incorrectly scaled by the typical current

Fixes #851

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Feb 24, 2020 •
edited
Loading

Codecov Report

Merging #852 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
+ Coverage   98.24%   98.26%   +0.01%     
==========================================
  Files         180      180              
  Lines       10276    10358      +82     
==========================================
+ Hits        10096    10178      +82     
  Misses        180      180
Impacted Files Coverage Δ
pybamm/parameters/parameter_values.py 100% <100%> (ø) ⬆️
...bamm/parameters/standard_parameters_lithium_ion.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1101ba...caa52a6. Read the comment docs.

valentinsulzer
valentinsulzer approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, good catch

@rtimms rtimms merged commit e517122 into master Feb 24, 2020
@rtimms rtimms deleted the issue-851-current-data-scale branch February 24, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brosaplanella brosaplanella brosaplanella approved these changes

@valentinsulzer valentinsulzer valentinsulzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current data gets scaled by I_typ
3 participants
@rtimms @valentinsulzer @brosaplanella